Scaling overhaul #1662
Draft
Scaling overhaul #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rescue files from overloaded git branch * fix due to api tweaks * run black * forgot to add a file * fix test errors * pin coolprop version * update version, disable superancillaries * run black * respond to Marcus's feedback * getting close * address Will's comments * tests for set_scaling_factor * support for unions in python 3.9 * testing the scaling profiler is way too fragile * modify test to be less fragile * remove pdb
* rescue files from overloaded git branch * fix due to api tweaks * run black * forgot to add a file * fix test errors * pin coolprop version * update version, disable superancillaries * run black * respond to Marcus's feedback * getting close * address Will's comments * tests for set_scaling_factor * support for unions in python 3.9 * testing the scaling profiler is way too fragile * modify test to be less fragile * remove pdb * rescue files from branch * towards scaling cv * preliminary testing * scaling by defn constraint * scale constraint by definition constraint * Disable obsolete tests for now * run black * actually add tests * inh * tests for methods rescued from old scaling tools * pylint * test to make sure that value is reverted * Apply suggestions from code review spelling fixes Co-authored-by: Brandon Paul <[email protected]> * additional clarity * more files rescued from branch --------- Co-authored-by: Brandon Paul <[email protected]>
* error for unnamed expressions * pylint * default is warning=False * make sure expression walker doesn't emit warnings * rescue files from different branch * tests for scaler base get_scaling_factor
dallan-keylogic
requested review from
bpaul4,
MAZamarripa and
agarciadiego
as code owners
* error for unnamed expressions * pylint * default is warning=False * make sure expression walker doesn't emit warnings * fix get_default_scaling_factor * no build on demand * not every component has lock attribute creation context * rescue files from different branch * avoid duplicate code and add tests * remove unused variable * fix spelling * pylint * changes suggested from review --------- Co-authored-by: Bethany Nicholson <[email protected]>
* rescue files from overloaded git branch * fix due to api tweaks * run black * forgot to add a file * fix test errors * pin coolprop version * update version, disable superancillaries * run black * respond to Marcus's feedback * getting close * address Will's comments * tests for set_scaling_factor * support for unions in python 3.9 * testing the scaling profiler is way too fragile * modify test to be less fragile * remove pdb * rescue files from branch * towards scaling cv * preliminary testing * scaling by defn constraint * scale constraint by definition constraint * Disable obsolete tests for now * run black * actually add tests * inh * tests for methods rescued from old scaling tools * pylint * test to make sure that value is reverted * Apply suggestions from code review spelling fixes Co-authored-by: Brandon Paul <[email protected]> * additional clarity * more files rescued from branch * rescue files from other branch * first tests * tests * additional scaling * more tests * fixes * run black * black on forgotten file * fix failing tests * fix issues when initializing FpcTP * begin scaling for cubic complementarity vle * error for unnamed expressions * pylint * enthalpy of formation test * default is warning=False * make sure expression walker doesn't emit warnings * Cubic complementarity VLE test * avoid auto-construction and run black * new scaling for test_BTIdeal_FcTP * BT ideal test * regularly scheduled scaling has been interrupted by a bug in scaling core * fix get_default_scaling_factor * tests for one more example ported * delegate scaling for solubility product forms * test FcPh * test FcTP * test_FpcTP * test FTPx * FPhx * no build on demand * not every component has lock attribute creation context * no more enth_mol_phase * run black * move to scaler object get scaling factor for future extension * get rid of remaing gsf and pylint changes * Actually scale cubic complementarity VLE and pylint * rescue files from different branch * tests for scaler base get_scaling_factor * remove dependency on fix_gdsf * pylint * maybe pylint will like this better * Is this acceptable to both pylint and black? * stash * fix failing test * black * pylint * minor tweaks * increase test coverage * avoid generation of properties * more test coverage for IdealBubbleDew * Renaming and comments * fix wrong constraint scaling method * reply to review comments * revert legacy test * failing test * improve error message * update authors * forgot to save file * fix exception match * Let's see if three solves is enough * less strict complementarity * xfail --------- Co-authored-by: Brandon Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
This PR is to compare the work we're doing on the feature branch
scaling_toolboxwith main and to run the CI tests we have to allow us to view CodeCov reports.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: